Repository navigation
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the REST options population logic to dynamically resolve the long-running operations endpoint using the configured universe domain via UniverseDomainEndpoint. It also adds comprehensive unit tests in populate_rest_options_test.cc to validate this behavior with various endpoint and universe domain configurations. I have no feedback to provide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16698 +/- ##
=======================================
Coverage 92.74% 92.75%
=======================================
Files 2271 2271
Lines 227219 227232 +13
=======================================
+ Hits 210734 210766 +32
+ Misses 16485 16466 -19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.